REST Class Modifications #61
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to delay longer so CPU doesn't get bogged down in context switching
…ty from a DownloadHandlerFile object
…ottler that deals with port exhaustion
The initial change is unneeded and should not be touched at this time just for safety.
This allows us to download files via a POST request, if needed. While this is not a common use case, we have an endpoint for module manifests that requires a body containing data to archive into a ZIP file. If Unity could send GET requests with a body, this wouldn't be an issue, but you can't.
mphilipp622
force-pushed
the
rest-modifications
branch
from
ac0e1b9 to
76a046c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several changes:
RestRequestThrottleris used to track active web requests and throttle them in a thread-safe manner. This is used to help prevent port exhaustion from sending too many simultaneous requests. Current values were determined by doing some basic performance testing on around 100 concurrent requests.