Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.2.dev1] Improve MNL estimation reliability #36

Merged
merged 4 commits into from
Aug 6, 2018
Merged

[0.2.dev1] Improve MNL estimation reliability #36

merged 4 commits into from
Aug 6, 2018

Conversation

smmaurer
Copy link
Member

@smmaurer smmaurer commented Aug 6, 2018

This PR replicates the fixes from UDST/urbansim#211.

  • reduces likelihood of matrix overflow by rescaling the utilities before exponentiating them
  • warns the user if scipy.optimize.fmin_l_bfgs_b reports not converging correctly

Versioning

  • updates choicemodels version number to 0.2.dev1

@coveralls
Copy link

coveralls commented Aug 6, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 52.545% when pulling e7ec8a1 on fix-runtime-overflow into 809ed5e on master.

@smmaurer smmaurer merged commit b3cb2b9 into master Aug 6, 2018
@smmaurer smmaurer deleted the fix-runtime-overflow branch August 6, 2018 22:50
@smmaurer smmaurer changed the title Improve MNL estimation reliability [0.2.dev1] Improve MNL estimation reliability Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smmaurer @coveralls @Eh2406