Remove unused torchvision dependency #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for removing this. The torchvision dependency prevents upgrading from torch 1.9.0. |
|
+1 for removing this dependency. Can we remove this? |
|
@nreimers can we get some movement on this? It seems any CLIP-related |
|
Is there anything preventing this branch from merging? I can try to contribute to the PR if there are some issues. |
|
There is not. This PR is ready as far as I'm concerned. I'd like to get this merged in the coming days.
|
|
Thanks a bunch for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torchvision is no longer used in the ST codebase, but it's still listed as a dependency. My guess is that whatever was using
torchvisionhas since been replaced bytransformersbut the dependency was never removed.This has also been pointed out by #1644