Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Always override the originally saved __version__ in the ST config #2709

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[fix] Always override the originally saved __version__ in the ST config #2709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions sentence_transformers/SentenceTransformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,12 +1004,11 @@ def save(
modules_config = []

# Save some model info
if "__version__" not in self._model_config:
self._model_config["__version__"] = {
"sentence_transformers": __version__,
"transformers": transformers.__version__,
"pytorch": torch.__version__,
}
self._model_config["__version__"] = {
"sentence_transformers": __version__,
"transformers": transformers.__version__,
"pytorch": torch.__version__,
}

with open(os.path.join(path, "config_sentence_transformers.json"), "w") as fOut:
config = self._model_config.copy()
Expand Down
11 changes: 11 additions & 0 deletions tests/test_sentence_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,3 +564,14 @@ def test_similarity_score_save(stsb_bert_tiny_model: SentenceTransformer) -> Non
assert loaded_model.similarity_fn_name == "euclidean"
dot_scores = model.similarity(embeddings, embeddings)
assert np.not_equal(cosine_scores, dot_scores).all()


def test_override_config_versions(stsb_bert_tiny_model: SentenceTransformer) -> None:
model = stsb_bert_tiny_model

assert model._model_config["__version__"]["sentence_transformers"] == "2.2.2"
with tempfile.TemporaryDirectory() as tmp_folder:
model.save(tmp_folder)
loaded_model = SentenceTransformer(tmp_folder)
# Verify that the version has now been updated when saving the model again
assert loaded_model._model_config["__version__"]["sentence_transformers"] != "2.2.2"
Loading