[fix] Fix MatryoshkaLoss crash if the first dimension is not the biggest
#2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this one will be cached for the other runs
I forgot to re-enable pre-commit, oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request overview
MatryoshkaLosscrash if the first dimension is not the biggestDetails
The first dimension is ran "normally", while all future ones use the cached results from the first run and then truncate to the required dimension. Consequently, if you use a non-largest dimension as the first dimension, then you'll cache a dimension that's too small. This PR sorts the Matryoshka dimensions from large to small to ensure that we cache the largest dimension.
Thanks @philschmid for reporting this.