Elasticsearch example: simplify setup #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions to run locally were simplified to omit TLS. Hence we can simplify this example script to skip the ssl_context part.
|
Hello! Excellent - thank you for taking the time to keep this up to date with the latest from ES! I'll try to run this myself to verify that it works.
|
|
Works wonderfully as long as you use ES v8.0+, otherwise the authentication gets ignored (I believe because you have to use Thank you for this!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions to run locally were simplified to omit TLS:
https://www.elastic.co/guide/en/elasticsearch/reference/current/run-elasticsearch-locally.html
Hence we can simplify this example script to skip the ssl_context part.
Also, the
hostscan now be a single URL and don't have to be a keyword arg anymore (see docs).