[fix] Change eval dataloader to use eval_batch_size
#2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think eval is more similar than train here
The former is identical for single-GPU and DDP, but has a higher batch size for DP (which is the expected behaviour).
|
Hello! Apologies for the delay, I've been recovering from a surgery this last month. Additionally, I started using
|
tomaarsen
changed the title
fix] Change eval dataloader to use eval_batch_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evaluation dataloader is currently initialized using the train_batch_size which seems to be a bug. This PR fixes this.