Perform additional check for owner string in is_<library>_available functions
#2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if you have a `datasets` module in your PYTHONPATH, the `is_datasets_available` function will return True, even if it's not the one from Huggingface. Here we add a slightly more complex logic to check the origin string of the importlib spec to match it against the expected owner.
That function returns a boolean, not None
tomaarsen
reviewed
Aug 20, 2024
leblancfg
force-pushed
the
importlib-datasets-spec-check
branch
from
ab0f9b4 to
acda278
Compare
Co-authored-by: Tom Aarsen <[email protected]>
leblancfg
force-pushed
the
importlib-datasets-spec-check
branch
from
acda278 to
eab0a28
Compare
|
I ran some tests locally, and it seems to work just like you'd hope now! Thanks a bunch, I'm merging this now. (We can ignore the CI test failures, they're unrelated due to disk space).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you have a
datasetsmodule in yoursys.path, theis_datasets_availablefunction will returnTrue, even if it's not the one from Huggingface.Here we add a slightly smarter logic to check the origin string of the
importlibspec, and match it against the expected owner. This makes it possible for users who also have an unrelated module in theirsys.pathcalleddatasetsto do imports likewhile leaving all other functionality untouched.
Closes #2858