Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] Load weights only with torch.load & pytorch_model.bin #2927

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

tomaarsen
Copy link
Collaborator

Hello!

Pull Request overview

  • Load weights only with torch.load & pytorch_model.bin

Details

Although usually you'd want to use safetensors anyways, this PR gets rid of a warning:

  [sic]\sentence_transformers\models\WordEmbeddings.py:108: FutureWarning: You are using `torch.load` with `weights_only=False` (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for `weights_only` will be flipped to `True`. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via `torch.serialization.add_safe_globals`. We recommend you start setting `weights_only=True` for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
    weights = torch.load(os.path.join(input_path, "pytorch_model.bin"), map_location=torch.device("cpu"))
  • Tom Aarsen

Although usually you'd want to use safetensors anyways
@tomaarsen tomaarsen merged commit ede5804 into UKPLab:master Sep 10, 2024
11 checks passed
@tomaarsen tomaarsen deleted the security/torch_load_weights_only branch September 10, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant