Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic flow and flowObject information to graphql #118

Open
wants to merge 41 commits into
base: HPC-8569-flow-list
Choose a base branch
from

Conversation

czmj
Copy link
Contributor

@czmj czmj commented Sep 19, 2022

EDITED

This PR add not only the SearchFlow resolver for GraphQL but also add lots of the nested relations with flow and flowObject.
This means that this PR include services and resolver for entities like: emergency, organisations, plans, clusters, etc.

Maybe the correct approach with this PR is to splice it up into smaller PRs or review Clara's commits individually (as was requested previously) and then review the new parts introduced this month.


ORIGINAL

Adds flow query with data on a specified flow (by id), along with flowObjects grouped by refDirection and objectType

Example query:

{
  flow(id: 14) {
    id
    versionID
    flowDate
    decisionDate
    firstReportedDate
    budgetYear
    origAmount
    origCurrency
    exchangeRate
    activeStatus
    newMoney
    restricted
    description
    notes
    versionStartDate
    versionEndDate
    createdBy
    lastUpdatedBy
    createdAt
    updatedAt
    deletedAt    
    flowObjects {
      source {
        organizations {
          id
          name
        }
      }
      destination {
        organizations {
          id
          name
        }
      }
    }
  }
}

A lot of this PR is doing the same thing for each object type - it might be easier to review each commit as the later ones are largely copy and paste

@czmj czmj requested a review from a team as a code owner September 19, 2022 20:19
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj added the ready for review All comments have been addressed, and the Pull Request is ready for review label Sep 19, 2022
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs assigned manelcecs and unassigned Pl217 Nov 16, 2023
@manelcecs manelcecs added pending prior merge Another Pull Request needs to be merged before this one blocked This PR is blocked on other work and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Nov 16, 2023
@manelcecs manelcecs force-pushed the HPC-8569-flow-list branch 7 times, most recently from e8c9724 to 9bfaf13 Compare April 26, 2024 12:03
@manelcecs manelcecs force-pushed the HPC-8569-flow-list branch 6 times, most recently from 70fc33b to 26f5a9b Compare May 6, 2024 10:55
@manelcecs manelcecs force-pushed the HPC-8569-flow-list branch 2 times, most recently from 29def00 to 10a16c4 Compare June 28, 2024 09:46
@manelcecs manelcecs force-pushed the HPC-8569-flow-list branch 2 times, most recently from 141f445 to b51ca0b Compare July 12, 2024 17:01
@manelcecs manelcecs force-pushed the HPC-8569-flow-list branch 5 times, most recently from c6f8825 to 0662d1c Compare August 19, 2024 07:04
@manelcecs manelcecs force-pushed the HPC-8569-flow-list branch 4 times, most recently from 39ba9a5 to e6cf143 Compare November 13, 2024 09:12
@manelcecs manelcecs force-pushed the HPC-8569-flow-list branch 2 times, most recently from be18333 to c4fb8b5 Compare November 26, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This PR is blocked on other work pending prior merge Another Pull Request needs to be merged before this one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants