Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPC-8569 flow list resolver #219

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

HPC-8569 flow list resolver #219

wants to merge 7 commits into from

Conversation

manelcecs
Copy link
Contributor

@manelcecs manelcecs commented Oct 30, 2023 •
edited
Loading

This PR add a new resolver for Flow Search.
Alongside add service for flows and nested entities linked with flows.
Also added test for resolver and util pagination methods.

:wq!

@manelcecs manelcecs requested a review from a team as a code owner October 30, 2023 09:42
unocha-hpc
unocha-hpc approved these changes Oct 31, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs self-assigned this Nov 1, 2023
unocha-hpc
unocha-hpc approved these changes Nov 2, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 6, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 6, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 6, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 6, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 6, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 8, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 8, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 8, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 9, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 9, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 10, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 11, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 12, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 13, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Nov 13, 2023
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs assigned Delgee and manelcecs and unassigned manelcecs and Delgee Nov 13, 2024
unocha-hpc
unocha-hpc approved these changes Nov 20, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs
Basic types for GraphQL resolvers
7748017 
Upgrade hpc-api-core with latest develop version
@manelcecs
Flow resolver and Args
d5ecf50 
Needed nested properties GQL types

merge 6c55177
@manelcecs
Flow search services
9e3e438 
Nested needed services to complete Flow response
@manelcecs
Add 'only-flow-conditions-strategy' implementation
2782b32 
Add also utils to operate over flows
@manelcecs
Add 'search-flow-by-filters-strategy' implementation
27fae32 
Nested strategies to find flowIDs from different filters

Merge 5de9ca3
@manelcecs
Add unit tests to cover search flows
e63c0d0 
Merge 141f445
unocha-hpc
unocha-hpc approved these changes Nov 26, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs added ready for review All comments have been addressed, and the Pull Request is ready for review and removed needs minor changes There are review or issue comments to address labels Nov 26, 2024
@manelcecs manelcecs assigned Delgee and unassigned manelcecs Nov 26, 2024
Delgee
Delgee approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Delgee Delgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing runtime checking on externalReference. Other than that looks good to me.

src/domain-services/flows/flow-service.ts
// because it does have a direct relation with flow
// and no direction
if (entity === 'externalReference') {
const column = orderBy.column as keyof InstanceOfModel<
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing runtime validation here

@Delgee Delgee assigned manelcecs and unassigned manelcecs Nov 29, 2024
@Delgee Delgee added needs minor changes There are review or issue comments to address and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Nov 29, 2024
unocha-hpc
unocha-hpc approved these changes Nov 29, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs added ready for review All comments have been addressed, and the Pull Request is ready for review and removed needs minor changes There are review or issue comments to address labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pl217 Pl217 Pl217 requested changes

@unocha-hpc unocha-hpc unocha-hpc approved these changes

@Delgee Delgee Delgee approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@Delgee Delgee

Labels
ready for review All comments have been addressed, and the Pull Request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manelcecs @Delgee @Pl217 @unocha-hpc