Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

excise dssecrets #11

Merged
merged 1 commit into from
Mar 30, 2023
Merged

excise dssecrets #11

merged 1 commit into from
Mar 30, 2023

Conversation

amsnyder
Copy link
Collaborator

@jesse-ross
Copy link
Contributor

Looks good! One difference I note is that the sb_replace_files_log function which is in USGS-R/slim-data-release-template#23 isn't here. I see that #6 mentions that function as well. I'm going to merge this as-is, but just wanted to explicitly note the difference.

@jesse-ross jesse-ross merged commit 7970888 into main Mar 30, 2023
@amsnyder
Copy link
Collaborator Author

@jesse-ross - that function wasn't in this PR because it was already in the code here:

sb_replace_files_log <- function(filename, sb_id, ..., file_hash, sources = c()){

I copied it from here into the slim-data-release PR.

@jesse-ross
Copy link
Contributor

that function wasn't in this PR because it was already in the code here:

Ohh - thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants