Development - SmartTabLayout 2 for ViewPager2 support #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- These changes will probably never go upstream Signed-off-by: Arka Prava Basu <[email protected]>
- the existing textview appearance parameters will be only used if there is no style supplied. These will be ignored provided there is a text appearance style applied for the tab view Signed-off-by: Arka Prava Basu <[email protected]>
- should move to compile only to reduce dependency burden on existing projects - WIP Signed-off-by: Arka Prava Basu <[email protected]>
- clients would not have to call setViewPager() again just for the changes in the adapter dataset Signed-off-by: Arka Prava Basu <[email protected]>
|
Need to revert 7c92e37 before this can go upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.