Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmake build does not honor CMAKE_INSTALL_MANDIR. #2920

Closed
chrisretusn opened this issue May 6, 2024 · 2 comments · Fixed by #2922
Closed

Cmake build does not honor CMAKE_INSTALL_MANDIR. #2920

chrisretusn opened this issue May 6, 2024 · 2 comments · Fixed by #2922

Comments

@chrisretusn
Copy link

NetCDF Version: 4.9.2
Host System: x86_64-Linux-6.6.30
Slackware64-current.
cc (GCC) 13.2.0
cmake version 3.29.2

Current behavior: When using -DCMAKE_INSTALL_MANDIR=/usr/man, manpages are place in /usr/share/man
Expected behavior: Manpage placed in /usr/man

To reproduce, this is my cmake build code:
cmake -B build -Wno-dev -Wno-deprecated
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_CXX_FLAGS_RELEASE="$SLKCFLAGS -DNDEBUG"
-DCMAKE_C_FLAGS_RELEASE="$SLKCFLAGS -DNDEBUG"
-DCMAKE_INSTALL_DOCDIR=/usr/doc/$PKGNAM-$PKGVER
-DCMAKE_INSTALL_MANDIR=/usr/man
-DCMAKE_INSTALL_PREFIX=/usr
-DCMAKE_VERBOSE_MAKEFILE=on
2>&1 | tee $OUTPUT/cmake.log
cmake --build build -j $NUMJOBS 2>&1 | tee $OUTPUT/build.log
DESTDIR=$PKGDIR cmake --install build --strip 2>&1 | tee $OUTPUT/install.log
@WardF
Copy link
Member

WardF commented May 7, 2024

Thanks, I'll get this fixed!

WardF added a commit to WardF/netcdf-c that referenced this issue May 7, 2024
@WardF
Modify CMakeLists.txt to honor CMAKE_INSTALL_MANDIR in support of Uni…
ebd3f36 
…data#2920.
@WardF WardF mentioned this issue May 7, 2024
Merged
@chrisretusn
Copy link
Author

Verified at my end!

ZedThree added a commit to ZedThree/netcdf-c that referenced this issue May 10, 2024
@ZedThree
Merge branch 'main' into silence-ncdap4-warnings
c841dce 
* main:
  Modify CMakeLists.txt to honor CMAKE_INSTALL_MANDIR in support of Unidata#2920.
  Modify ncdump to print char-valued variables as utf8.
  removal of ftp and contrib site
  removal of ftp site
  removal of ftp and netcdf contrib site
  removal of ftp and netcdf contrib site
  comment
  ftp --> resources for sample data location
  ftp--> resources for sample data location
  CMake: Enable plugins on MinGW
  Reintroduce targets to allow for cmake-based netCDF-Fortran to find and linka gainst netCDF-C. Stop-gap measure until we can modify netCDF-Fortran to use a more modern approach.
  revert
  ckp
  test1
  debug1
ZedThree added a commit to ZedThree/netcdf-c that referenced this issue May 16, 2024
@ZedThree
Merge branch 'main' into silence-libdap2-warnings
780bf94 
* main: (29 commits)
  ftp --> resources
  Update release notes
  Convert the ENABLE_XXX options to NETCDF_ENABLE_XXX options
  Modify CMakeLists.txt to honor CMAKE_INSTALL_MANDIR in support of Unidata#2920.
  Modify ncdump to print char-valued variables as utf8.
  CI: Create an MSYS2/MinGW CMake run.
  CI: Test on MSYS2/UCRT64 environment
  CMake: Fix running tests on MinGW
  removal of ftp and contrib site
  removal of ftp site
  removal of ftp and netcdf contrib site
  removal of ftp and netcdf contrib site
  comment
  ftp --> resources for sample data location
  ftp--> resources for sample data location
  CMake: Enable plugins on MinGW
  Reintroduce targets to allow for cmake-based netCDF-Fortran to find and linka gainst netCDF-C. Stop-gap measure until we can modify netCDF-Fortran to use a more modern approach.
  revert
  Fix conversion warning in flag set/check/clear macros
  ckp
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Honor CMAKE_INSTALL_MANDIR WardF/netcdf-c
2 participants
@WardF @chrisretusn