Use explicit casts in nc4_convert_type to silence warnings

[ZedThree]

No description provided.

[DennisHeimbigner]

I am confused by the changes to nc4var.c.
For example, line 729 is left as:
*sp++ = *ubp++;
but should it not be this?
*sp++ = (short)*ubp++;

[ZedThree]

So I only added casts to lines that generate conversion warnings. I'm pretty sure that unsigned char* is implicitly castable to any other type, as it's used for raw memory access.

I could add the casts to the other lines here for consistency.

[DennisHeimbigner]

So I only added casts to lines that generate conversion warnings. I'm pretty sure that unsigned char* is implicitly castable to any other type, as it's used for raw memory access.

I could add the casts to the other lines here for consistency.

Thanks for the clarification. No need to modify for consistency, I think.