Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most warnings in dumplib.c #2814

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

ZedThree
Copy link
Contributor

The easy win here was changing the return type of sbuf_len which is used in a lot of places in this file. Two alternatives that I think would be cleaner but require touching more places:

  1. Change the typ_tostring_func function pointer typedef to return size_t. This is more correct as it matches the current return type of sbuf_len, which is returned from the implementations of this prototype.
  2. Change the typ_tostring_func return type to void -- as far as I can tell, the return value of these functions isn't used anywhere that they're called, I think it's an entirely internal module. Doing this would also mean that the call to sbuf_len in these functions could also be removed entirely

This PR fixes about 55 warnings

@WardF WardF merged commit ad53ef4 into Unidata:main Mar 20, 2024
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants