Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The easy win here was changing the return type of
sbuf_len
which is used in a lot of places in this file. Two alternatives that I think would be cleaner but require touching more places:typ_tostring_func
function pointer typedef to returnsize_t
. This is more correct as it matches the current return type ofsbuf_len
, which is returned from the implementations of this prototype.typ_tostring_func
return type tovoid
-- as far as I can tell, the return value of these functions isn't used anywhere that they're called, I think it's an entirely internal module. Doing this would also mean that the call tosbuf_len
in these functions could also be removed entirelyThis PR fixes about 55 warnings