Link against internally defined libraries #2837
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither #2595 nor #2758 fully addressed the underlying issue that final
netcdf
target linking was failing due to missing dependencies previously defined in other internal targets. While a valid solution to manually specify linking dependencies again, part of the effort is to make use of the target structure in cmake to further inform future linking.The usage of the generator expression
$<TARGET_OBJECTS:...>
negates any target-specific linking that ought to be inherited to thenetcdf
target. To avoid this issue internal targets such asdispatch
should be directly linked. Since targetnetcdf
does not havePUBLIC/PRIVATE
definitions for its linking, a compromise for now is to use the$<TARGET_NAME_IF_EXISTS:...>
generator expression which will fully fix linking even prior to #2595 / #2758 and a valid config able to be found/imported by other cmake projects.