Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link against internally defined libraries #2837

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

islas
Copy link
Contributor

@islas islas commented Jan 8, 2024

Neither #2595 nor #2758 fully addressed the underlying issue that final netcdf target linking was failing due to missing dependencies previously defined in other internal targets. While a valid solution to manually specify linking dependencies again, part of the effort is to make use of the target structure in cmake to further inform future linking.

The usage of the generator expression $<TARGET_OBJECTS:...> negates any target-specific linking that ought to be inherited to the netcdf target. To avoid this issue internal targets such as dispatch should be directly linked. Since target netcdf does not have PUBLIC/PRIVATE definitions for its linking, a compromise for now is to use the $<TARGET_NAME_IF_EXISTS:...> generator expression which will fully fix linking even prior to #2595 / #2758 and a valid config able to be found/imported by other cmake projects.

@islas
Copy link
Contributor Author

islas commented Jan 25, 2024

@WardF Is there a good way to re-queue the tests? It looks like the Cygwin tests failed with some server request error - as far as I can tell not related to the code changes.

@WardF
Copy link
Member

WardF commented Jan 27, 2024

I've re-queued them and we will see what happens :)

@WardF WardF merged commit 41166da into Unidata:main Jan 29, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants