Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc clang-tidy fixes, and added a .clang-tidy config file #2875

Merged
merged 14 commits into from
Apr 5, 2024

Conversation

seanm
Copy link
Contributor

@seanm seanm commented Mar 2, 2024

This fixes some clang-tidy warnings.

Some were fixed automatically by the tool.

Some were fixed manually by me after the tool warned about them.

I've added a clang-tidy config file that results in no warnings (because of my fixes and disabling of other warning options.)

@ZedThree
Copy link
Contributor

ZedThree commented Mar 8, 2024

It looks like the failing tests timed out -- might be the perennial remote test issues?

@WardF
Copy link
Member

WardF commented Mar 8, 2024

It looks like the failing tests timed out -- might be the perennial remote test issues?

Quite possible; let me take a closer look :).

@WardF WardF self-assigned this Apr 2, 2024
@WardF WardF added this to the 4.9.3 milestone Apr 2, 2024
@WardF
Copy link
Member

WardF commented Apr 5, 2024

@DennisHeimbigner I am reviewing this but before I sign off on it, I notice a couple small changes to files in libnczarr/. I know you're working on a major refactor, do the changes in these files interfere?

@DennisHeimbigner
Copy link
Collaborator

@DennisHeimbigner I am reviewing this but before I sign off on it, I notice a couple small changes to files in libnczarr/. I know you're working on a major refactor, do the changes in these files interfere?

They look benign to me. Go ahead.

@WardF
Copy link
Member

WardF commented Apr 5, 2024

@DennisHeimbigner I am reviewing this but before I sign off on it, I notice a couple small changes to files in libnczarr/. I know you're working on a major refactor, do the changes in these files interfere?

They look benign to me. Go ahead.

Thanks, @DennisHeimbigner !

@WardF WardF merged commit 9639ba4 into Unidata:main Apr 5, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants