-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc clang-tidy fixes, and added a .clang-tidy config file #2875
Conversation
It looks like the failing tests timed out -- might be the perennial remote test issues? |
Quite possible; let me take a closer look :). |
@DennisHeimbigner I am reviewing this but before I sign off on it, I notice a couple small changes to files in |
They look benign to me. Go ahead. |
Thanks, @DennisHeimbigner ! |
This fixes some clang-tidy warnings.
Some were fixed automatically by the tool.
Some were fixed manually by me after the tool warned about them.
I've added a clang-tidy config file that results in no warnings (because of my fixes and disabling of other warning options.)