Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt at adding windows-based Github Action CI #2908

Closed
wants to merge 93 commits into from
Closed

Attempt at adding windows-based Github Action CI #2908

wants to merge 93 commits into from

Conversation

WardF
Copy link
Member

@WardF WardF commented Apr 9, 2024 •
edited
Loading

Do not merge.

@WardF WardF requested a review from DennisHeimbigner as a code owner April 9, 2024 17:48
@WardF WardF marked this pull request as draft April 9, 2024 17:48
WardF added 27 commits April 9, 2024 11:49
@WardF
Specify bash shell.
0b41547
@WardF
Replace wget with curl.
edfd81b
@WardF
Use miniconda to install dependencies.
43e90bf
@WardF
Correct syntax error.
2256184
@WardF
Update conda working environment.
42984bf
@WardF
Adjust shell invocation for Windows test.
88222a6
@WardF
Set base to always activate.
795b1a0
@WardF
Making progress, step forward and investigate the current environment.
991e870
@WardF
Attempt initial build.
6a2e261
@WardF
Attempt to install m4 via pacman package manager.
be5f150
@WardF
Alternate approach to install m4.
6d02348
@WardF
Set prefix path.
11d72bb
@WardF
Correct typo
a702a7e
@WardF
Add diagnostic printline.
e51b374
@WardF
A different approach to setting environmental variable.
9ad193d
@WardF
Querying environmental variable.
a0948d4
@WardF
Checking a syntax thing.
f24f93a
@WardF
Attempt more straightforward approach.
855a687
@WardF
Progress. Add stanzas to build libnetcdf and then test suite.
40470f2
@WardF
Add libxml2 to install manifest.
29377ce
@WardF
Add cmake_c_flags.
3c59493
@WardF
Address strange error observed.
6b79207
@WardF
Correct basic mistake.
80723fa
@WardF
Add stanza to print out config.h in case of failure.
7fe48c8
@WardF
Trying something I shouldn't need to set manually.
0852e08
@WardF
Modifying previous fix.
9224b80
@WardF
Removing extraneous line.
0986f01
@WardF
Copy link
Member Author

WardF commented Apr 10, 2024

It looks like we're finally getting somewhere; I'll be closing this PR tomorrow and putting up a new one, absent all the debug pushes. This new PR will see a more polished version of the script, which will in turn lead (after the upcoming release) to adoption of a more typical multi-platform config file.

WardF added 19 commits April 10, 2024 17:02
@WardF
Run all tests, not just the nc_test4 subset.
6ad444a
@WardF
Isolate test failures.
c51ded4
@WardF
Make failed tests under Windows CI run in serial fashion.
243cda7
@WardF
Disable filter testing
dc83236
@WardF
Add verbose flag to run_nccopyz.sh
57c400b
@WardF
Add verbose flag to tst_bom.sh script.
f2c77aa
@WardF
Move to msys2 shell from github bash shell.
0f0468c
@WardF
Using msys2 directly was worth a shot.
1eb6882
@WardF
Restrict the testing to the current two failures.
26fbe6e
@WardF
Replace literal tab and carriage return with posix character class.
53ca392
@WardF
Try different shell.
2b13344
@WardF
Escaping a single quote.
ae1d9e9
@WardF
No content.
80742bd
@WardF
Try to work around tr error on Windows runner.
de9112b
@WardF
Remove test now passing, focus on bom test.
1acab85
@WardF
Add debugging statement.
963f6e4
@WardF
Remove stray line.
18302cd
@WardF
Try excluding bom test from Windows CI
a38d149
@WardF
Clean up script.
f18da85
@WardF WardF mentioned this pull request Apr 17, 2024
Merged
@WardF WardF closed this Apr 17, 2024
@WardF WardF deleted the add_windows_github_action.wif branch April 17, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LecrisUT LecrisUT LecrisUT left review comments

@dopplershift dopplershift dopplershift left review comments

@DennisHeimbigner DennisHeimbigner Awaiting requested review from DennisHeimbigner DennisHeimbigner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WardF @dopplershift @LecrisUT