Fix ordering in CMakeLists.txt #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration of the `nc-config` file uses some symbols that were not defined until later in the file. This caused the quantize and zstd support lines to be incorrect.
|
Thank you @gsjaardema I was literally just poking around at this for the 4.9.3 release candidate, thanks! I'll get it merged in once the checks complete. |
WardF
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration of the
nc-configfile uses some symbols that were not defined until later in the file. This caused the quantize and zstd support lines to be incorrect.This PR moves the configuration of nc-config after all of the
is_enabledvariable setting calls. It is now close to the other generated files (libnetcdf.settings and netcdf_meta.h) which also use those symbols