Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5.3]: Fix GRIB IOSP to ensure time coordinates are monotonically increasing #1060

Closed
1 task done
ethanrd opened this issue Aug 11, 2022 · 4 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working

Comments

@ethanrd
Copy link
Member

ethanrd commented Aug 11, 2022

Versions impacted by the bug

v5.x

What went wrong?

For variables where the data values are valid on a time interval, e.g., total precipitation, the GRIB IOSP calculates time coordinates from the set of time intervals specified in the GRIB records. When the set of time intervals are irregular and overlapping, using the mid-point of each interval as the time coordinate values can result in a coordinate variable that is not monotonically increasing.

Relevant stack trace

No response

Relevant log messages

No response

If you have an example file that you can share, please attach it to this issue.

If so, may we include it in our test datasets to help ensure the bug does not return once fixed?
Note: the test datasets are publicly accessible without restriction.

N/A

Code of Conduct

  • I agree to follow the UCAR/Unidata Code of Conduct
@ethanrd ethanrd added the bug Something isn't working label Aug 11, 2022
@ethanrd ethanrd self-assigned this Aug 11, 2022
@ethanrd
Copy link
Member Author

ethanrd commented Aug 11, 2022

This issue (and soon to be added PRs) replaces PR #1043 in order to separate the solution for datasets with 1-D time from the solution for FMRC datasets with 2-D time (model run and valid).

@ethanrd
Copy link
Member Author

ethanrd commented Aug 11, 2022

I have solution for datasets with 1-D time and will submit soon, probably early next week. Still working on solution for FMRC datasets with 2-D time.

@pedro-cf
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants