-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.5.3]: Fix GRIB IOSP time coords from intervals, for 2-D time datasets #1248
[5.5.3]: Fix GRIB IOSP time coords from intervals, for 2-D time datasets #1248
Conversation
a981823
to
0a0493f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran all the tests on Jenkins against your branch and one is failing: https://jenkins-aws.unidata.ucar.edu/view/Users/job/tara-netcdf-java/35/
In the TestGribCompareBuilders
tests it looks like it is comparing the builder/ non-builder versions for all files in ../grib/src/test/data/
and it looks like there's a difference for the new file you added. I do not believe this is actually related to your changes (I ran the test with that file on maint-5.x
and it also failed). Since it's unrelated and I'm not sure how important it is that the with/without builders return identical results, maybe it's easiest to just ignore that new test file in that test and possibly fix it later.
grib/src/main/java/ucar/nc2/grib/collection/GribTimeCoordIntervalUtils.java
Outdated
Show resolved
Hide resolved
grib/src/main/java/ucar/nc2/grib/collection/GribTimeCoordIntervalUtils.java
Outdated
Show resolved
Hide resolved
grib/src/test/java/ucar/nc2/grib/coord/TestDiscontiguousInterval.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tara Drwenski <[email protected]>
Co-authored-by: Tara Drwenski <[email protected]>
Agree, probably easier to ignore the new test file. Are there other test files excluded from this test? |
Just pushed a fix to ignore that test case! |
Description of Changes
Fix generation of time coordinate variables from time intervals for 2-D time datasets. Ensure resulting time coordinate variables are strictly monotonically increasing. Handle when time intervals are irregular and overlapping.
See issue #1060.
PR Checklist
until ready for review