New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization for inflating data #1294

Merged

haileyajohnson merged 3 commits into Unidata:maint-5.x from tdrwenski:out-of-memory-error

Jan 26, 2024

Contributor

tdrwenski commented Jan 25, 2024 •

edited

Loading

Description of Changes

A possible performance improvement of Deflate::decode.

Use try with resources to ensure resources are always closed
Initialize ByteArrayOutputStream with approximate capacity to avoid extra resizes (this is the capacity used in TDS 4.x)

Tara Drwenski added 3 commits

January 25, 2024 10:37


          Use try with resources

97a2aa2


          Initialize output stream capacity to approx length

b5e602d


          Style fix

50f176b

tdrwenski marked this pull request as ready for review

January 25, 2024 23:41

tdrwenski requested a review from haileyajohnson as a code owner

January 25, 2024 23:41

haileyajohnson approved these changes

View reviewed changes

haileyajohnson merged commit 5a35e5b into Unidata:maint-5.x

10 checks passed

tdrwenski deleted the out-of-memory-error branch

February 26, 2024 16:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet