Make IActuator implement IHeuristicProvider. #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surfnerd
changed the base branch from
v2-staging
to
v2-staging-disable-dotnet-format
surfnerd
force-pushed
the
develop-actuator-heuristic-merge
branch
from
7762c1b
to
b223e53
Compare
surfnerd
changed the base branch from
v2-staging-disable-dotnet-format
to
v2-staging
surfnerd
force-pushed
the
develop-actuator-heuristic-merge
branch
from
b223e53
to
b459af4
Compare
dongruoping
reviewed
Mar 15, 2021
| @@ -3,7 +3,7 @@ namespace Unity.MLAgents.Actuators | |||
| /// <summary> | |||
| /// Abstraction that facilitates the execution of actions. | |||
| /// </summary> | |||
| public interface IActuator : IActionReceiver | |||
| public interface IActuator : IActionReceiver, IHeuristicProvider | |||
There was a problem hiding this comment.
Do we still need this to be a separate interface with only one method? Can it be part of IActionReceiver?
There was a problem hiding this comment.
Hmm, good point. I made IActionReceiver in order to help with backward compatibility. Let me think about this.
There was a problem hiding this comment.
I think for now i'd like to leave it the way it is as it allows for indirection of actions. There might be an actuator that you want to write that delegates actions to other action receivers. maybe in a robotics use case or something.
dongruoping
approved these changes
Mar 15, 2021
surfnerd
added a commit
that referenced
this pull request
Mar 18, 2021
surfnerd
added a commit
that referenced
this pull request
Mar 18, 2021
surfnerd
added a commit
that referenced
this pull request
Mar 18, 2021
surfnerd
added a commit
that referenced
this pull request
Mar 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Have IActuator implement IHeuristicProvider.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
MLA-1799
MLA-1826
Types of change(s)
Checklist
Other comments