Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid empty set iteration, avoid Debug.AssertFormat #5246

Merged
merged 2 commits into from
Apr 13, 2021
Merged

avoid empty set iteration, avoid Debug.AssertFormat #5246

merged 2 commits into from
Apr 13, 2021

Conversation

chriselion
Copy link
Contributor

Proposed change(s)

Remove some extra sources of garbage-collected memory during runtime:

  • Don't iterate of the set of DemonstrationRecorders if it's empty (this still allocates an iterator).
  • Wrap calls to Debug.AssertFormat in their own condition (this still allocates the object[] for the parameters).

Before

image
image

After

image

Types of change(s)

  • Bug fix

Checklist

Other comments

@chriselion chriselion merged commit 6f1ad81 into main Apr 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the misc-gc-removal branch April 13, 2021 00:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surfnerd surfnerd surfnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @surfnerd