Custom trainer editor analytics #5511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpierre
commented
Aug 24, 2021
|
|
||
| msg = TrainingEnvironmentInitialized( | ||
| python_version=f"{vi[0]}.{vi[1]}.{vi[2]}", | ||
| mlagents_version="Custom", |
There was a problem hiding this comment.
This is the main piece. "Custom" will be sent instead of the mlagents version.
vincentpierre
commented
Aug 24, 2021
ml-agents-envs/mlagents_envs/side_channel/default_training_analytics_side_channel.py
Outdated
Show resolved
Hide resolved
vincentpierre
commented
Aug 24, 2021
ml-agents-envs/mlagents_envs/side_channel/default_training_analytics_side_channel.py
Outdated
Show resolved
Hide resolved
sini
reviewed
Aug 31, 2021
ml-agents-envs/mlagents_envs/side_channel/default_training_analytics_side_channel.py
Outdated
Show resolved
Hide resolved
sini
approved these changes
Sep 2, 2021
maryamhonari
changed the title
…to clean up channels. (#5283)
…am changes (#5528) Pre-commit is using a version of dotnet and dotnet-format and has picked up a newer version of the utility that is not compatible with .NET 3.1 or 5.x -- it installs it's packages using dotnet tool install. This version's default entrypoint is also incompatible with our project structure, as the style and analyzer subcommands are now run by default and do not support the --folder option. The entrypoint can be over-ridden to specify the whitespace module, which should match previous behavior.
* init from any checkpoint including older ones * moving init_path logic ahead to learn.py * fixing pytest to take the full path * doc & changelog
* Fixed failing test due to gym 0.20.0 release. Updated gym-unity package to fix gym version to 0.20.0. * Updated CHANGELOG.
3Dball doc correction
maryamhonari
added a commit
that referenced
this pull request
Oct 6, 2021
maryamhonari
pushed a commit
that referenced
this pull request
Oct 13, 2021
maryamhonari
pushed a commit
that referenced
this pull request
Oct 13, 2021
10 tasks
maryamhonari
added a commit
that referenced
this pull request
Oct 18, 2021
* init petting_zoo registry * cherrypick Custom trainer editor analytics (#5511) * cherrypick "Update dotnet-format to address breaking changes introduced by upstream changes (#5528)" * Update colab to match pettingZoo import api * ToRevert: pull exp-petting-registry branch * Add init file to tests * Install pettingzoo-unity requirements for pytest * update pytest command * Add docstrings and comments * update coverage to pettingzoo folder * unset log level * update env string
maryamhonari
added a commit
that referenced
this pull request
Nov 2, 2021
…) (#5584) * update changelog from #5511 * set gym=0.20.0 #5540, update changelog * Cap cattrs version for now(#5397) * clean up Co-authored-by: Vincent-Pierre BERGES <[email protected]> Co-authored-by: Ruo-Ping Dong <[email protected]>
maryamhonari
added a commit
that referenced
this pull request
Nov 4, 2021
* update package version from 2.0.0 to 2.0.1 * Update README.md with new survey link(#5500) (#5585) Co-authored-by: jmercado1985 <[email protected]> * [Cherry-pick for 2.0.1 verified patch] default analytics channel (#5511) (#5584) * update changelog from #5511 * set gym=0.20.0 #5540, update changelog * Cap cattrs version for now(#5397) * clean up Co-authored-by: Vincent-Pierre BERGES <[email protected]> Co-authored-by: Ruo-Ping Dong <[email protected]> * Cherry picking #5283 and #5519 into 2.0.1-verified-patch to fix gRPC for mac m1 (MLA 2259) (#5602) * Only update the native library and the c# calls that need to be made to clean up channels. (#5283) * Fix Mac backcompat test (#5519) Co-authored-by: Chris Goy <[email protected]> * [Cherry-pick for 2.0.1 verified patch]Harden user PII in analytics (#5512) harden analytics (#5604) * Harden user PII protection logic and extend TrainingAnalytics to expose detailed configuration parameters. (#5512) * Hash128 is not a cryptographic hash, replace with HMAC-SHA256. * Extend TrainingAnalytics side channel to expose configuration details * Change member function scopes and hash demo_paths * Extract tbiEvent hashing method and add test coverage * Fixing the analytics side-channel for curriculum learning. (#5586) * Fixing the analytics side-channel for curriculum learning. * Made a more robust test. * Update the changelog. * Update com.unity.ml-agents/CHANGELOG.md Co-authored-by: Maryam Honari <[email protected]> Co-authored-by: Maryam Honari <[email protected]> * update CHANGELOG Co-authored-by: Jason Bowman <[email protected]> Co-authored-by: jmercado1985 <[email protected]> Co-authored-by: Vincent-Pierre BERGES <[email protected]> Co-authored-by: Ruo-Ping Dong <[email protected]> Co-authored-by: Jason Rupert <[email protected]> Co-authored-by: Chris Goy <[email protected]> Co-authored-by: Jason Bowman <[email protected]>
miguelalonsojr
pushed a commit
that referenced
this pull request
Jan 27, 2022
* init petting_zoo registry * cherrypick Custom trainer editor analytics (#5511) * cherrypick "Update dotnet-format to address breaking changes introduced by upstream changes (#5528)" * Update colab to match pettingZoo import api * ToRevert: pull exp-petting-registry branch * Add init file to tests * Install pettingzoo-unity requirements for pytest * update pytest command * Add docstrings and comments * update coverage to pettingzoo folder * unset log level * update env string
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC for sending default training analytics when a custom trainer is being used.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Jira: https://jira.unity3d.com/browse/MLA-2180
Types of change(s)
Checklist
Other comments
Feature functionality is covered by existing test coverage. I can add additional test coverage for the PII scrubbing private methods.