Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Installation.md #6004

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

xyz2022
Copy link
Contributor

@xyz2022 xyz2022 commented Oct 31, 2023

Removing "or higher" because:
(i) ./ml-agents/setup.py requires >=3.10.1,<=3.10.12 (ii) python 3.10.13 is the default conda install, and 3.10.13 does not work correctly with numpy 1.21.2

Proposed change(s)

Remove the phrase "or higher" from "Install Python 3.10.12 or Higher"

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

30fbd50

This is one issue related to the "or higher" clause on the python version:
#6002

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Removing "or higher" because:
(i) ./ml-agents/setup.py requires >=3.10.1,<=3.10.12 
(ii) python 3.10.13 is the default conda install, and 3.10.13 does not work correctly with numpy 1.21.2
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@alex-mccarthy-unity alex-mccarthy-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our docs! I'll merge this in.

@alex-mccarthy-unity alex-mccarthy-unity merged commit ed807e3 into Unity-Technologies:develop Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants