Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuous integration tests across incompatible editor versions (2022 and trunk) #6079

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

alex-mccarthy-unity
Copy link
Collaborator

@alex-mccarthy-unity alex-mccarthy-unity commented Mar 12, 2024

Proposed change(s)

  • Run all CI tests on Unity 2023: stop running tests on 2022
  • Disable the RigidBodySensorTests.TestBodiesWithJoint that fails in 2023 due to a suspected physx change
  • Disable trunk tests, which break with Unity 6
  • Refactor tests to use positions instead of hardcoded numbers
  • Print full diffs when a sensor mismatch occurs in tests
  • Ignore yamato-parser output files

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Run all CI tests against 2023.2 (required by Sentis), not 2022.3

Sample failing sub-jobs before: https://unity-ci.cds.internal.unity3d.com/job/35022030/dependency-graph
Sample passing sub-jobs after: https://unity-ci.cds.internal.unity3d.com/job/35033024/dependency-graph

Note that `trunk` jobs are still failing after this fix.
Those will be investigated separately since they've been failing since March 8: https://unity-ci.cds.internal.unity3d.com/job/34919178/dependency-graph
Clean run of "Run All Combinations of Editors/Platforms Tests" after this change: https://unity-ci.cds.internal.unity3d.com/job/35037130/dependency-graph
@alex-mccarthy-unity alex-mccarthy-unity changed the title Run all CI tests against 2023.2 (required by Sentis), not 2022.3 Fix continuous integration tests across incompatible editor versions (2022 and trunk) Mar 12, 2024
@miguelalonsojr miguelalonsojr merged commit 93221d4 into develop Mar 13, 2024
23 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-editor-version-ci branch March 13, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants