Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add person attributes for mode choice #77

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Conversation

Hussein-Mahfouz
Copy link
Collaborator

@Hussein-Mahfouz Hussein-Mahfouz commented Dec 3, 2024

Main changes include adding functions to mark individuals as students, passengers, and public transport subscribers, and updating the configuration to support these new attributes.

Key changes include:

New Functions for Attribute Processing:

  • Added functions get_passengers, get_pt_subscription, and get_students to src/acbm/postprocessing/matsim.py to add person attributes: isStudent, isPassenger, hasPTsubscription, sex

Updates to the Main Script:

  • Modified scripts/5_acbm_to_matsim_xml.py to include the new functions and process additional attributes like sex, student status, passenger status, and public transport subscription status, as well as vehicle ownership attributes CarAvailability, BicycleAvailability, hasLicense

Configuration Updates:

  • Updated the Postprocessing class in src/acbm/config.py to include new configuration parameters: student_age_base, student_age_upper, modes_passenger, and pt_subscription_age.

@sgreenbury
Copy link
Collaborator

As discussed, we can merge this now to ensure these features are available from the pipeline when #71 is merged. Enabling config to specify additional columns for upstream outputs would be a good option relating to #78.

@Hussein-Mahfouz Hussein-Mahfouz merged commit 1cec3f7 into main Dec 13, 2024
4 checks passed
@sgreenbury sgreenbury mentioned this pull request Jan 10, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants