-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added private modes #127
Added private modes #127
Conversation
Added some private modes to IndividualModesEnumeration, e.g. scooter, ride-pool-car, car-sharing, cycle-sharing, scooter-sharing.
Do the names of those modes have to be aligned with some standard? |
Let's ask the NeTEx new modes guys? |
Actually, I did not have a look at NeTEx. the result of our discussion in the last call was, that this extension of the IndividualModesEnumeration should be quickly extended by usual modes. In parallel we planned to place an issue at SIRI for extending the PrivateModeChoiceGroup by standard individual modes like "walk", "own-bike", "own-car". If they do so, we could use this SIRI:PrivateModeChoiceGroup withint OJP 2.0. |
Then we should add a note, that this may change in v2.0 when being more conform with Siri. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve this with the condition that within OJP 2.0 this will solved by SIRI not by custom lists.
Can you please explain the motivation behind including sharing services within individual travel modes? (That is, if I understrand correctly what car-sharing, cycle-sharing and scooter-sharing mean). |
Yes, within responses sharing services are supposed to fill the SharingService element in ContinuousLeg. Still an explicit mode type does not conflict with this information. |
Added some private modes to IndividualModesEnumeration, e.g. scooter, ride-pool-car, car-sharing, cycle-sharing, scooter-sharing.