Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added private modes #127

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Added private modes #127

merged 1 commit into from
Dec 3, 2020

Conversation

pvgrumbkow
Copy link
Contributor

Added some private modes to IndividualModesEnumeration, e.g. scooter, ride-pool-car, car-sharing, cycle-sharing, scooter-sharing.

Added some private modes to IndividualModesEnumeration, e.g. scooter, ride-pool-car, car-sharing, cycle-sharing, scooter-sharing.
@pvgrumbkow pvgrumbkow added the enhancement New feature or request label Nov 30, 2020
@pvgrumbkow pvgrumbkow added this to the v1.1 milestone Nov 30, 2020
@sgrossberndt
Copy link
Contributor

Do the names of those modes have to be aligned with some standard?
"cycle-sharing" vs "bicycle-sharing"

@skinkie
Copy link
Contributor

skinkie commented Nov 30, 2020

Do the names of those modes have to be aligned with some standard?
"cycle-sharing" vs "bicycle-sharing"

Let's ask the NeTEx new modes guys?

@pvgrumbkow
Copy link
Contributor Author

Actually, I did not have a look at NeTEx. the result of our discussion in the last call was, that this extension of the IndividualModesEnumeration should be quickly extended by usual modes. In parallel we planned to place an issue at SIRI for extending the PrivateModeChoiceGroup by standard individual modes like "walk", "own-bike", "own-car". If they do so, we could use this SIRI:PrivateModeChoiceGroup withint OJP 2.0.
However, I propose to extend the current enumeration for OJP 1.1 in a very simple way (keeping the current wording) and to plan a proper extension via SIRI for OJP 2.0.

@ue71603
Copy link
Contributor

ue71603 commented Dec 2, 2020

Then we should add a note, that this may change in v2.0 when being more conform with Siri.

Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve this with the condition that within OJP 2.0 this will solved by SIRI not by custom lists.

@sgrossberndt sgrossberndt requested a review from ue71603 December 3, 2020 11:19
@pvgrumbkow pvgrumbkow merged commit c18a4ea into changes_for_v1.1 Dec 3, 2020
@pvgrumbkow pvgrumbkow deleted the AddedPrivateModes branch December 3, 2020 14:58
@karsa-mistmere
Copy link

Can you please explain the motivation behind including sharing services within individual travel modes? (That is, if I understrand correctly what car-sharing, cycle-sharing and scooter-sharing mean).
Aren't sharing services supposed to be represented via a SharingService tag in ContinuousLeg trip legs?
Thank you for your reply in advance.

@pvgrumbkow
Copy link
Contributor Author

Yes, within responses sharing services are supposed to fill the SharingService element in ContinuousLeg. Still an explicit mode type does not conflict with this information.
But actually, the extension of IndividualModes was necessary for trip requests. Within requests it was beforehand not possible to allow sharing services. That was the reason to extend the IndividualModes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlaceContextStructure/IndividualTransportOptions lacks siri:PrivateModeChoiceGroup
5 participants