Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PublicCode of the journey to DatedJourney and ContinuousService #201

Merged
merged 15 commits into from
Nov 7, 2022
Merged

Add PublicCode of the journey to DatedJourney and ContinuousService #201

merged 15 commits into from
Nov 7, 2022

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented May 26, 2022

mostly as View to present things to customers

@ue71603
Update Service with PublishedJourneyName and OperatorName
b0703fd 
mostly as View to present things to customers
@ue71603 ue71603 added enhancement New feature or request documentation labels May 26, 2022
@ue71603 ue71603 added this to the v2.0 milestone May 26, 2022
AndreasAtSBB
AndreasAtSBB previously approved these changes Jul 25, 2022
View reviewed changes
Copy link

@AndreasAtSBB AndreasAtSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PublishedJourneyName added after JourneyRef
operatorName added after OperatorRef

Aurige
Aurige reviewed Aug 22, 2022
View reviewed changes
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 changed the title Update Service with PublishedJourneyName and OperatorName Update Service with Public Code (for the Journey) and OperatorName Aug 25, 2022
Aurige
Aurige previously approved these changes Aug 26, 2022
View reviewed changes
sgrossberndt
sgrossberndt reviewed Aug 30, 2022
View reviewed changes
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
@sgrossberndt sgrossberndt changed the title Update Service with Public Code (for the Journey) and OperatorName Add PublicCode of the journey and OperatorName to DatedJourney and ContinuousService Aug 30, 2022
Aurige
Aurige previously approved these changes Oct 3, 2022
View reviewed changes
@ue71603
Removed OperatorName
fd8ec64 
as it will be handled by adding Operator to the context.
@ue71603 ue71603 requested a review from Aurige October 18, 2022 11:16
skinkie
skinkie previously approved these changes Oct 18, 2022
View reviewed changes
@skinkie skinkie changed the title Add PublicCode of the journey and OperatorName to DatedJourney and ContinuousService Add PublicCode of the journey to DatedJourney and ContinuousService Oct 18, 2022
sgrossberndt
sgrossberndt requested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@sgrossberndt sgrossberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still do not understand what a "public code" of a journey is. Is it some kind of ID? Should it be shown to customers? Is it meant to refer to journeys by it? If yes, in which context? Is this defined anywhere so we could add this information to the annotation?

Aurige
Aurige previously approved these changes Oct 19, 2022
View reviewed changes
@Aurige
Copy link
Contributor

Aurige commented Oct 19, 2022

I still do not understand what a "public code" of a journey is. Is it some kind of ID? Should it be shown to customers? Is it meant to refer to journeys by it? If yes, in which context? Is this defined anywhere so we could add this information to the annotation?

For example, in Ile de France, the urban trains (RER) have a short code, that is shown to the public (on timetable, displays on the platform and in vehicles) because there are a lot of different branches and destination and passengers need to be sure what train they are jumping in. This code is short enough to be shown even on old displays.

sgrossberndt
sgrossberndt previously requested changes Oct 19, 2022
View reviewed changes
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 dismissed stale reviews from Aurige and skinkie via b8c0075 October 26, 2022 12:25
@ue71603 ue71603 dismissed sgrossberndt’s stale review November 4, 2022 23:48

resolved in a later commit

@ue71603
Copy link
Contributor Author

ue71603 commented Nov 4, 2022

@sgrossberndt Can you live with the clarification or still a problem?

@sgrossberndt sgrossberndt merged commit 7613309 into changes_for_v1.1 Nov 7, 2022
@sgrossberndt sgrossberndt deleted the update_Service2 branch November 7, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinkie skinkie skinkie approved these changes

@Aurige Aurige Aurige approved these changes

@sgrossberndt sgrossberndt sgrossberndt approved these changes

@herlitze herlitze Awaiting requested review from herlitze

@normanoffel normanoffel Awaiting requested review from normanoffel

@AndreasAtSBB AndreasAtSBB Awaiting requested review from AndreasAtSBB

Assignees
No one assigned
Labels
doc updated enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ue71603 @Aurige @skinkie @sgrossberndt @AndreasAtSBB @trurlurl