Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to resolve #71

Closed
Bernhardino opened this issue Oct 21, 2018 · 9 comments
Closed

Failed to resolve #71

Bernhardino opened this issue Oct 21, 2018 · 9 comments

Comments

@Bernhardino
Copy link

Bernhardino commented Oct 21, 2018

I've got the same issue as #68 (closed): "failed to resolve com.github.chrisbanes:PhotoView:2.0.0"

What was/is the solution for this problem?

@darsh-sn
Copy link

darsh-sn commented Dec 9, 2018

even i got the same issue. Not able to build the gradle :/

@VEINHORN
Copy link
Owner

VEINHORN commented Dec 9, 2018

@Bernhardino @darsh-sn Hi! I have just rebuild project and PhotoView library was successfully fetched from Maven Repository. What version of Android Studio do you use and how do you build project?

@Bernhardino
Copy link
Author

Bernhardino commented Dec 10, 2018 via email

@VEINHORN
Copy link
Owner

@Bernhardino Hi! It would be nice if you can provide more details (such as logs, screenshots, etc).

@Bernhardino
Copy link
Author

The error "Failed to resolve: com.github.chrisbanes:PhotoView:2.0.0" shows up in the very first beginning when I add to "build.gradle" the line

"compile 'com.veinhorn.scrollgalleryview:library:1.0.8' "

(or better "implementation 'com.veinhorn.scrollgalleryview:library:1.0.8' ", because "compile ..." is deprecated) and then press "sync".

@VEINHORN
Copy link
Owner

@Bernhardino year, I saw your email.

Did you add the jcenter() repo to your top level build.gradle script? Here you can find an example.

@Bernhardino
Copy link
Author

Hello Boris
Yes, "jcenter()" is listed by default. But good news: I added the missing line "maven { url 'https://jitpack.io' }" from your example, and now your ScrollGalleryView works for me! Do I have to add the 2 missing lines "mavenCentral()" also? And: I think you should mention this solution on https://github.com/VEINHORN/ScrollGalleryView. Thank you for your help.

@VEINHORN
Copy link
Owner

VEINHORN commented Dec 12, 2018

@Bernhardino Hello!

In my opinion, to resolve ScrollGalleryView library you just need jcenter() repository in your build.gradle script cause it's published on JCenter, but maybe something changed from that time. So I'll try to check this more precisly in near future and update docs accordingly.

I'm glad that adding JitPack repository helped you to solve your problem.

Thank you. You are welcome. 👍

@VEINHORN
Copy link
Owner

VEINHORN commented Jan 4, 2019

Updated Installing chapter in README cause ScrollGalleryView library uses PhotoView library which is hosted on JitPack.

So we need to add JitPack repository to our root build.gradle:

allprojects {
  repositories {
    // ...
    maven { url 'https://jitpack.io' }
  }
}

@VEINHORN VEINHORN closed this as completed Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants