Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time dependent IPR graphs for NN cleaning #230

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Conversation

GernotMaier
Copy link
Member

@GernotMaier GernotMaier commented Apr 5, 2023

Development for the implementation of time-dependent IPR graph generation to be used for the NN cleaning. This should allow to take into account changing NSB conditions during a run and use always the optimal cleaning levels.

Plans:

  • IPR graphs are filled in time bins similar to the time dependent pedestal mechanism
  • allow to use events from non-triggered telescopes to increase event statistics for the IPR graph filling.

(development is on hold for now and will continue later)

@@ -5,6 +5,11 @@

#include "VImageBaseAnalyzer.h"
#include "VPedestalCalculator.h"
#include "VIPRCalculator.h"
#include "VDB_CalibrationInfo.h"
#include <VSQLTextFileReader.h>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use for includes always "" and not <>

#ifndef VIPRCALCULATOR_H
#define VIPRCALCULATOR_H

#include <VImageBaseAnalyzer.h>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, please use always "VImageBaseAnalyzer.h" (comment valid for all other Eventdisplay classes)

bool fIPRAverageTel; // flag to make average of all telescopes IPR in case there is not enough statistics to produce IPR graphs
bool fIPRInTimeSlices;
int fPedPerTelescopeTypeMinCnt;
<<<<<<< HEAD
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge comments!

@@ -0,0 +1,62 @@
#ifndef VIPRCALCULATOR_H
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What file is .h.bsk?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a typo, the file should have been deleted with all other backup files.

@GernotMaier
Copy link
Member Author

@mariakherlakian - note that the current code seg faults when running pedestal calculations:

Telescope (type) 1
	 total number of pedestal events: 1024
	 writing  high  gain pedestals to
		/lustre/fs23/group/veritas/users/maierg/analysis/Results/v490/NN/test/Calibration/Tel_1/64080.ped
		/lustre/fs23/group/veritas/users/maierg/analysis/Results/v490/NN/test/Calibration/Tel_1/64080.ped.root
	 filling pedestal tree for telescope 1 (telescope type 1)
	 number of time slices for pedestals in telescope 1: 6

 *** Break *** segmentation violation



===========================================================
There was a crash.
This is the entire stack trace of all threads:
===========================================================
#0  0x00002b4d64d794fc in waitpid () from /lib64/libc.so.6
#1  0x00002b4d64cf6fb2 in do_system () from /lib64/libc.so.6
#2  0x00002b4d5ebd4d84 in TUnixSystem::StackTrace() () from /afs/ifh.de/group/cta/cta/software/root/root-6.24.06_build/lib/libCore.so
#3  0x00002b4d5ebd69fa in TUnixSystem::DispatchSignals(ESignals) () from /afs/ifh.de/group/cta/cta/software/root/root-6.24.06_build/lib/libCore.so
#4  <signal handler called>
#5  0x0000000000520360 in VCalibrator::writePeds (this=0x2881f70, iLowGain=false, iPedestalCalculator=iPedestalCalculator
entry=0x28ed500, iWriteAsciiFile=true, fIPRCalculator=0x29a2670) at src/VCalibrator.cpp:522
#6  0x0000000000520aef in VCalibrator::terminate (this=<optimized out>, iP=iP
entry=0x28ed500, fIPRCalculator=<optimized out>) at src/VCalibrator.cpp:1616
#7  0x000000000056e8ec in VEventLoop::shutdown (this=this
entry=0x7ffcb7e96660) at src/VEventLoop.cpp:829
#8  0x000000000045b5ae in main (argc=11, argv=0x7ffcb7e96fa8) at src/evndisp.cpp:66
===========================================================


The lines below might hint at the cause of the crash.
You may get help by asking at the ROOT forum https://root.cern.ch/forum
Only if you are really convinced it is a bug in ROOT then please submit a
report at https://root.cern.ch/bugs Please post the ENTIRE stack trace
from above as an attachment in addition to anything else
that might help us fixing this issue.
===========================================================
#5  0x0000000000520360 in VCalibrator::writePeds (this=0x2881f70, iLowGain=false, iPedestalCalculator=iPedestalCalculator
entry=0x28ed500, iWriteAsciiFile=true, fIPRCalculator=0x29a2670) at src/VCalibrator.cpp:522
#6  0x0000000000520aef in VCalibrator::terminate (this=<optimized out>, iP=iP
entry=0x28ed500, fIPRCalculator=<optimized out>) at src/VCalibrator.cpp:1616
#7  0x000000000056e8ec in VEventLoop::shutdown (this=this
entry=0x7ffcb7e96660) at src/VEventLoop.cpp:829
#8  0x000000000045b5ae in main (argc=11, argv=0x7ffcb7e96fa8) at src/evndisp.cpp:66
===========================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants