-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time dependent IPR graphs for NN cleaning #230
base: main
Are you sure you want to change the base?
Conversation
Conflicts: src/VTS.getRunListFromDB.cpp
Conflicts: inc/VCalibrator.h inc/VEvndispRunParameter.h inc/VImageCleaning.h src/VCalibrator.cpp src/VImageCleaning.cpp
inc/VCalibrator.h
Outdated
@@ -5,6 +5,11 @@ | |||
|
|||
#include "VImageBaseAnalyzer.h" | |||
#include "VPedestalCalculator.h" | |||
#include "VIPRCalculator.h" | |||
#include "VDB_CalibrationInfo.h" | |||
#include <VSQLTextFileReader.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use for includes always "" and not <>
#ifndef VIPRCALCULATOR_H | ||
#define VIPRCALCULATOR_H | ||
|
||
#include <VImageBaseAnalyzer.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, please use always "VImageBaseAnalyzer.h"
(comment valid for all other Eventdisplay classes)
inc/VIPRCalculator.h
Outdated
bool fIPRAverageTel; // flag to make average of all telescopes IPR in case there is not enough statistics to produce IPR graphs | ||
bool fIPRInTimeSlices; | ||
int fPedPerTelescopeTypeMinCnt; | ||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge comments!
inc/VIPRCalculator.h.bsk
Outdated
@@ -0,0 +1,62 @@ | |||
#ifndef VIPRCALCULATOR_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What file is .h.bsk
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a typo, the file should have been deleted with all other backup files.
@mariakherlakian - note that the current code seg faults when running pedestal calculations:
|
Development for the implementation of time-dependent IPR graph generation to be used for the NN cleaning. This should allow to take into account changing NSB conditions during a run and use always the optimal cleaning levels.
Plans:
(development is on hold for now and will continue later)