Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate alpha correction for significance distributions #17

Open
steob92 opened this issue Feb 13, 2024 · 2 comments
Open

Investigate alpha correction for significance distributions #17

steob92 opened this issue Feb 13, 2024 · 2 comments
Assignees
@millmj
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@steob92
Copy link
Collaborator

steob92 commented Feb 13, 2024

See slides from @millmj :

conv = on_area / bin_area
alpha_conv = alpha * conv
@steob92 steob92 added bug Something isn't working help wanted Extra attention is needed labels Feb 13, 2024
@samanthalwong
Copy link
Collaborator

See here for the fix: gammapy/gammapy#5270

@steob92 steob92 reopened this Jul 29, 2024
@steob92
Copy link
Collaborator Author

steob92 commented Jul 29, 2024

We should add some instructions until gammapy 1.3 is available.

steob92 added a commit that referenced this issue Jul 29, 2024
@steob92
fix(gammapy-tools.def): patching the change for the RBM maps issue
b62d32f 
#17
steob92 added a commit that referenced this issue Jul 29, 2024
@steob92
fix(gammapy-tools.def-pyproject.toml): adding gammapy main as a depen…
f40eb35 
…dency

#17
@steob92 steob92 mentioned this issue Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millmj millmj

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steob92 @samanthalwong @millmj