Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust]onnxruntimeをrust版voicevox_coreに導入 #135
[Rust]onnxruntimeをrust版voicevox_coreに導入 #135
Changes from 7 commits
6a986d0
6bbe029
7edc8c7
3563c1a
fb51a18
3c8b004
93062cf
5258c05
6d11919
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
内部で発生したエラーをError内部のsourceとして保持するために導入
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directmlでbuildするかどうかで出力されるコードを変えたかったので条件わけしやすいように導入した
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コミットIDの指定ってできそうでしょうか👀
指定しておくと、今後qwertyさんがご自身のonnxruntime-rsを気軽に修正できそうだなと思い。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コミットID指定もできたはずですが、version指定のほうがやりやすいのでこっちにさせていただいて良いでしょうか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コミットID指定だとバージョンアップするたびにコミットIDを調べないといけないのでちょっと面倒です
version指定だとonnxruntime-rs projectのcargo file内のversionを更新する必要がありますが、こっちのほうが使う側は特に何も考えずにインクリメントればよいので楽かなと
あとversionの更新はきちんとやるべきだと思いますし
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほどです!バージョンが良さそうに感じました!
(変更があまり発生しなさそうになったらぜひvoicevox側でもメンテしたいですね…!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enumの場合はrepr(i32)が正しいらしいので修正