[Rust]pythonのexampleを新しい形に変更した #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CIでのpython example確認はもともとのCIでもなかったので追加していないです |
Co-authored-by: Hiroshiba <[email protected]>
PickledChair
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
LGTM！
CIでのpython example確認はもともとのCIでもなかったので追加していないです
ということですが、Python パッケージとしてインストールした時の動作確認（実質的に元の _core.py のテスト）は CI でも python setup.py test で行われていそうでした。それと関連して、https://github.com/qwerty2501/voicevox_core/blob/d27bdb865e479924fac056f134561ad9c354d33e/README.md?plain=1#L161-L171 あたりの記述は現在はうまくいかないですね。この記述や、setup.py, tests/core_test.py はこのままにしておきますか？
|
あ〜たしかにREADMEのその記述は無いほうが親切ですね･･･！ |
|
@PickledChair @Hiroshiba READMEの手順を削除しました |
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
example内で完結させるため core.pyをexample/python内に配置し、installしていなくても実行できるようにした
installしてなくても実行できるようにcoreダウンロード手順を追加
関連 Issue
refs #128
その他