cbindgenにfn.args=verticalを設定し、__declspecの後の空行を消す
#518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
?????...この空行無いと駄目なやつ...? |
qryxip
commented
Jun 11, 2023
| @@ -206,8 +204,7 @@ VoicevoxResultCode voicevox_initialize(struct VoicevoxInitializeOptions options) | |||
| */ | |||
| #ifdef _WIN32 | |||
| __declspec(dllimport) | |||
| #endif | |||
| const char *voicevox_get_version(void); | |||
There was a problem hiding this comment.
|
調べた結果、 |
|
いや |
qryxip
changed the title
__declspec(dllimport)と関数定義の隙間の空行を消すfn.args=verticalを設定し、__declspecの後の空行を消す
qryxip
commented
Jun 11, 2023
Comment on lines
-210
to
+208
| const char *voicevox_get_version(void); | ||
| const char *voicevox_get_version(void); |
There was a problem hiding this comment.
fn.args=verticalを設定したことで、この妙なスペース一文字も消えました。
Hiroshiba
approved these changes
Jun 11, 2023
|
たぶん問題ないと思うのでマージします！ |
This was referenced Jun 12, 2023
Merged
Hiroshiba
added a commit
that referenced
this pull request
Jun 12, 2023
* Docs: 事例紹介にvoicevoxcore.goを追加 (#498) Docs: 事例紹介のvoicevoxcore.goを追加 * 間違った`char*`の解放を明示的に拒否する (#500) * Cargo.tomlをフォーマットする (#504) * Update rust toolchain 1.70.0 (#506) Co-authored-by: PickledChair <[email protected]> Co-authored-by: Ryo Yamashita <[email protected]> * Rust APIのbuild.rsを抹消する (#508) * Python APIでは`panic=unwind`にする (#505) * Python APIでは`panic=unwind`にする * C APIは`-C panic=abort`でビルドする * READMEのスペースが足りてなかった (#511) * windows-latestでなぜかdownload_testが落ちるのを改修 (#517) * windows-latestでなぜかdownload_testが落ちるのを修正 * a * cbindgenに`fn.args=vertical`を設定し、`__declspec`の後の空行を消す (#518) * `__declspec(dllimport)`と関数定義の隙間の空行を消す * `fn.args="vertical"`を設定 * cbindgenの`include_version`を有効化する (#519) * cbindgenの`include_version`を有効化する * jobをリネーム * 誤字 --------- Co-authored-by: Kota Amasaka <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PickledChair <[email protected]> Co-authored-by: Hiroshiba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
voicevox_core/crates/voicevox_core_c_api/include/voicevox_core.h
Lines 192 to 201 in 5de8ddf
この空行を消します。
/** * 初期化する * @param [in] options 初期化オプション * @return 結果コード #VoicevoxResultCode */ #ifdef _WIN32 __declspec(dllimport) #endif - VoicevoxResultCode voicevox_initialize(struct VoicevoxInitializeOptions options);Rustの最初の実装 (#126)からずっとこうだったようですが、この部分について何か議論した跡も無さそうなので、この空行はない方が視認性が高いかなと思いPRを出しておきます。
関連 Issue
その他