New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(riscv): Check electron version and bump to 29.4.0.riscv3 #1965

Merged

daiyam merged 2 commits into VSCodium:master from kxxt:riscv-1

Jul 21, 2024

Contributor

kxxt commented Jul 21, 2024

Add a check that fails when the riscv electron version doesn't match .yarnrc.
- This ensures that we won't produce broken releases when they don't match and signal that the riscv electron version should be bumped.
Bump riscv electron to v29.4.0.riscv3 for SIGILL on rdcycle, which becomes a privileged instruction since linux 6.6 riscv-forks/electron#2

kxxt added 2 commits

July 21, 2024 10:01


          build(riscv): catch electron version mismatch

c3a709e


          build(riscv): bump electron to v29.4.0.riscv3

f7b63a9

Fix riscv-forks/electron#2

daiyam merged commit 092d140 into VSCodium:master

21 checks passed

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet