feat: loong64 support for reh server #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch is way better... |
|
Is the PR finished? |
|
I think so, do you have any other comments? |
|
I've made few modifications specially for |
darkyzhou
added a commit
to darkyzhou/vscodium
that referenced
this pull request
Nov 7, 2024
darkyzhou
added a commit
to darkyzhou/vscodium
that referenced
this pull request
Nov 7, 2024
darkyzhou
added a commit
to darkyzhou/vscodium
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, previous PR somehow was closed "by myself", but I was just re-syncing the PR branch, didn't know what GitHub was doing :/
Anyway, this PR addresses all the issues and TODOs from previous PR.