Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic solver interface #222

Merged
merged 38 commits into from
Nov 20, 2020
Merged

Generic solver interface #222

merged 38 commits into from
Nov 20, 2020

Conversation

evaleev
Copy link
Member

@evaleev evaleev commented Oct 16, 2020

  • reorg scalapack code
  • add lapack solvers for
    • DistArray (collective)
      • cholesky
        • cholesky
        • cholesky_inv
        • cholesky_solve
        • cholesky_lsolve
      • heig
        • std
        • generalized
      • lu
      • svd
    • contiguous tensors (non-collective)
      • cholesky
        • cholesky
        • cholesky_inv
        • cholesky_solve
        • cholesky_lsolve
      • heig
      • lu
      • svd

@evaleev
Copy link
Member Author

evaleev commented Oct 16, 2020

@wavefunction91 FYI I started on the generic interface. Unfortunately probably need to reorder arguments in scalapack solver API to bring all non-scalapack-specific args forward. This will probably break some NWX code

# Conflicts:
#	src/TiledArray/external/btas.h
@evaleev evaleev added this to the release 1.1 milestone Nov 17, 2020
@evaleev
Copy link
Member Author

evaleev commented Nov 17, 2020

@asadchev F* API signatures differ between MADNESS and the rest of the world, so need smth like:

#ifndef  MADNESS_LINALG_USE_LAPACKE
  TA_LAPACK_CALL(
    gesvd,
    &jobu, &jobvt, &m, &n, a, &lda, s, u, &ldu, vt, &ldvt, &lwork_dummy, &lwork, &info,
    sizeof(char), sizeof(char)
  );
#else
  TA_LAPACK_CALL(
      gesvd,
      &jobu, &jobvt, &m, &n, a, &lda, s, u, &ldu, vt, &ldvt, &lwork_dummy, &lwork, &info
  );
#endif

or do metaprogramming magic dropping by-value args

@asadchev asadchev marked this pull request as ready for review November 20, 2020 21:46
@asadchev asadchev merged commit b2f3ab2 into tot_devel Nov 20, 2020
@evaleev evaleev deleted the generic-algebra branch January 10, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants