Asadchev/refactor/lapack #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaleev
reviewed
Dec 18, 2020
| - echo 'localhost slots=8' > /etc/openmpi/openmpi-default-hostfile | ||
| - apt-get install -yq intel-mkl-core-c-2020.4-304 | ||
| - ln -s /opt/intel/compilers_and_libraries_2020.4.304/linux/mkl/ /opt/intel/ |
There was a problem hiding this comment.
better to load /opt/intel/compilers_and_libraries_2020.4.304/linux/mkl/bin/mklvars.sh to test discovery from MKLROOT-defined location?
There was a problem hiding this comment.
i had that at first, but this seems more common case
| TA_LAPACKE_CALL(z##name, args); \ | ||
| else if constexpr (std::is_same_v<numeric_type, std::complex<float>>) \ | ||
| TA_LAPACKE_CALL(c##name, args); \ | ||
| TA_LAPACK_CALL(s##name, args); \ |
There was a problem hiding this comment.
compile issues due to constexpr defificencies.
asadchev
force-pushed
the
asadchev/refactor/lapack
branch
4 times, most recently
from
b7c1bd2 to
6b02df5
Compare
asadchev
force-pushed
the
asadchev/refactor/lapack
branch
from
6b02df5 to
72551ef
Compare
evaleev
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.