Refactor TA_ASSERT #259
Merged
Refactor TA_ASSERT #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaleev
reviewed
Mar 14, 2021
src/TiledArray/error.h
Outdated
| class Exception : public std::exception { | ||
| public: | ||
| Exception(const char* m) : message_(m) {} | ||
| void Abort(); |
There was a problem hiding this comment.
uppercase is weird for function names ... is this is to avoid clashing with std::abort? How about renaming to ta_abort() then?
asadchev
force-pushed
the
asadchev/refactor/ta-assert
branch
from
1b88205 to
77e5932
Compare
asadchev
force-pushed
the
asadchev/refactor/ta-assert
branch
from
77e5932 to
9394446
Compare
evaleev
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.