Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix fill_random() method #295

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Bug fix fill_random() method #295

merged 2 commits into from
Jul 12, 2021

Conversation

bimalgaudel
Copy link
Member

No description provided.

bimalgaudel
bimalgaudel commented Jul 11, 2021
View reviewed changes
Copy link
Member Author

@bimalgaudel bimalgaudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think , return static_cast<ValueType>(static_cast<double>(std::rand()) / RAND_MAX);
is better than the current line ie. return static_cast<ValueType>(std::rand()) / RAND_MAX;

@evaleev evaleev merged commit ac4edbb into master Jul 12, 2021
@evaleev evaleev deleted the bimalgaudel-patch-1 branch July 12, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bimalgaudel @evaleev