Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build deps, if not found, via FetchContent, NOT ExternalProject #300

Merged
merged 8 commits into from
Aug 27, 2021

Conversation

evaleev
Copy link
Member

@evaleev evaleev commented Aug 25, 2021

No description provided.

@evaleev evaleev force-pushed the evaleev/cmake/bye-external-project branch from ed4f497 to 34c7698 Compare August 26, 2021 11:20
@evaleev evaleev merged commit 5451c1d into master Aug 27, 2021
@evaleev evaleev deleted the evaleev/cmake/bye-external-project branch August 27, 2021 11:22
@evaleev evaleev restored the evaleev/cmake/bye-external-project branch August 27, 2021 11:29
@evaleev evaleev deleted the evaleev/cmake/bye-external-project branch August 27, 2021 12:01
@evaleev
Copy link
Member Author

evaleev commented Aug 27, 2021

Cannot completely get rid of ExternalProject! Umpire uses BLT, which is not sub projectable in TA due to duplicate target names (docs in MADNESS, check everywhere).

So leaving complete elimination of ExternalProject to another day (i.e., when really needed). For the record, currently using EP for Eigen, Umpire, and cuTT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant