Asadchev/feature/eigen einsum #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaleev
reviewed
Jun 1, 2022
| BOOST_AUTO_TEST_SUITE_END() | ||
|
|
||
| // TiledArray einsum expressions | ||
| BOOST_AUTO_TEST_SUITE(einsum_tiledarray, TA_UT_LABEL_SERIAL) |
There was a problem hiding this comment.
Parallel isnt working yet, second PR this week will enable it
|
Parallel execution is still not done, next pr will enable it
…On Tue, May 31, 2022, 9:19 PM Eduard Valeyev ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/einsum.cpp
<#344 (comment)>
:
> + auto A = random<T>(nh,nj,ni);
+ auto B = random<T>(nj,ni,nh);
+ using R = Eigen::Tensor<T,2>;
+ R result = einsum<R>("hji,jih->hj", A, B);
+ R reference = einsum< Eigen::Tensor<T,1> >(
+ "hi,hi->h",
+ A.shuffle(array{0,1,2}).reshape(array{nh*nj,ni}),
+ B.shuffle(array{2,0,1}).reshape(array{nh*nj,ni})
+ ).reshape(array{nh,nj});
+ BOOST_CHECK(isApprox(reference, result));
+}
+
+BOOST_AUTO_TEST_SUITE_END()
+
+// TiledArray einsum expressions
+BOOST_AUTO_TEST_SUITE(einsum_tiledarray, TA_UT_LABEL_SERIAL)
this should test with >1 rank?
—
Reply to this email directly, view it on GitHub
<#344 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH62KB4FBUBNT4JHYHVNXLVM2UCFANCNFSM5XOVAM5Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.