fix distarray lifetime in init_tiles and assignment #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_ (like the destructor) and inherits other's defer_deleter_to_next_fence_ flag
…e that it outlives the tasks
asadchev
force-pushed
the
evaleev/fix/distarray-lifetime-in-init-tiles-and-assignment
branch
from
5e6af9a to
2d7e4bf
Compare
evaleev
deleted the
evaleev/fix/distarray-lifetime-in-init-tiles-and-assignment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
besides minor cosmetic changes this
DistArray::operator=(other)to respectdefer_deleter_to_next_fence_just likeDistArraydtor; it also copies theother.defer_deleter_to_next_fence_flagDistArray::init_tilesensures that its tasks outlivepimpl_by deferring its destruction to the next fence