Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*TsrExpr manages lifetime of the array object referred by the bound variable #380

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

evaleev
Copy link
Member

@evaleev evaleev commented Dec 15, 2022

TsrExpr<Array> expr;
{
  Array a;
  expr = a("I,j");
}
// expr.array() returns ref to a, i.e. invalid
// expr.array_value() returns Array referring to a's implementation object

… (but not the variable it is bount to) to avoid issues with building complex expressions in stages

squash! *TsrExpr manages the lifetime of the array that it is bound to to avoid issues with building complex expressions in stages
@evaleev evaleev force-pushed the evaleev/fix/tsr-expr-manage-array-lifetime branch from c92f0ef to 781b9ca Compare December 16, 2022 13:01
@evaleev evaleev merged commit 97f08c9 into master Dec 16, 2022
@evaleev evaleev deleted the evaleev/fix/tsr-expr-manage-array-lifetime branch December 16, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant