Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make_array when target shape is rank-1 #414

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

wavefunction91
Copy link

Current HEAD catches an ambiguity in Tensor::operator[](index) / Tensor::operator[](ordinal) for rank-1 tensors. This was not being handled properly in make_array when the target shape was rank-1.

@wavefunction91
Copy link
Author

@evaleev
Copy link
Member

evaleev commented Aug 21, 2023

@evaleev Any sense why https://gitlab.com/ValeevGroup/tiledarray/-/jobs/4894910049 fails?

seems to be a stochastic failure in librett_suite/librett_gpu_mem ... @victor-anisimov , this might be due to cudaMemcpy not actually completing its transfer before librett kernel starting work (on its non-default stream; at least https://docs.nvidia.com/cuda/cuda-runtime-api/api-sync-behavior.html#api-sync-behavior__memcpy-sync indicates that non-pinned host to device transfers or vice versa return before transfers complete). I think it makes sense to schedule all transfers on the same (non default) stream as used by the librett kernel. thoughts?

EDIT: here's the relevant CI log fragment:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants