fix stream handling in multi-op device tasks #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 25, 2023
evaleev
force-pushed
the
420-stream-assignment-to-device-tasks-should-be-sticky
branch
from
1393bc3 to
b4b5997
Compare
- initial support for multiple devices - introduced device::Stream - sticky handling of streams should allow device tasks with multiple ops (e.g., scale+permute) to work correctly
This reverts commit b4b5997.
…ed with quiet=false
evaleev
force-pushed
the
420-stream-assignment-to-device-tasks-should-be-sticky
branch
from
ca59376 to
5ea446b
Compare
|
currently 
and https://gitlab.com/ValeevGroup/tiledarray/-/jobs/5177464289#L1687 |
…me, not CUDA runtime
…, but in task body so that streams are per-task, not per thread in case a task recursively executes other tasks by doing Future::get(dowork=true)
evaleev
force-pushed
the
420-stream-assignment-to-device-tasks-should-be-sticky
branch
from
de1c368 to
2134056
Compare
…upport + MADNESS tag to pull in m-a-d-n-e-s-s/madness#501
evaleev
force-pushed
the
420-stream-assignment-to-device-tasks-should-be-sticky
branch
from
2134056 to
dfa3f76
Compare
…ic decisions and need for locking
evaleev
force-pushed
the
420-stream-assignment-to-device-tasks-should-be-sticky
branch
from
c612b71 to
4b79b5a
Compare
This was referenced Sep 29, 2023
evaleev
deleted the
420-stream-assignment-to-device-tasks-should-be-sticky
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #420 and #422