Integration-report - Work in progress #125
Conversation
viniciusgama
force-pushed
the
integration_report
branch
from
e60f310 to
0e67a15
Compare
|
@ebragaparah can you check if I messed something after the merge? all things you did in the other PR are still in place? |
|
You mean, should I check if the code I put in my PR is present in this one? Have you already merged this version to my latest code? I couldn't find my changes here. |
|
exactly @ebragaparah |
|
Algumas tarefas pendentes:
|
|
All my changes are there after your changes, folks! |
| if (!found) { | ||
| $scope.placeDetails.occurrences.push(addPlaceFromForm($scope.report)); | ||
| } | ||
| } |
There was a problem hiding this comment.
I liked it! I agree with you folks that this statement is just bringing complexity to this controller since we don't need to group the occurrences here.
| $scope.placeDetails.occurrences.push(addPlaceFromForm($scope.report)); | ||
| } | ||
| } | ||
| $http.post(ApiEndpoint.url, addPlaceFromForm($scope.report), {}) |
There was a problem hiding this comment.
Maybe it's a good ideia to delegate this $http.post for an specific service that can be injected here. Since it's not an urgency, we can add this to our tech debit wall (I took notes on this).
| @@ -39,7 +39,8 @@ | |||
| "moment": "^2.17.1", | |||
| "phantomjs": "^1.9.18", | |||
| "protractor": "^4.0.8", | |||
| "protractor-jasmine2-screenshot-reporter": "^0.3.1" | |||
| "protractor-jasmine2-screenshot-reporter": "^0.3.1", | |||
| "stubby": "^4.0.0" | |||
There was a problem hiding this comment.
It looks nice! I'll take a look on this library after.
…tion with back-end and front-and
…lder in package.json
viniciusgama
force-pushed
the
integration_report
branch
from
ee8e136 to
fafbc57
Compare
Integração front-end e back-end da funcionalidade para reportar um risco